Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

Left sidebar bug ( documentation / examples ) #145

Closed
LukyVj opened this issue May 2, 2016 · 5 comments
Closed

Left sidebar bug ( documentation / examples ) #145

LukyVj opened this issue May 2, 2016 · 5 comments

Comments

@LukyVj
Copy link
Member

LukyVj commented May 2, 2016

As said on the #places channel, I can see a strange bug on the left menu, on the documentation and the examples.

If I start to scroll, the menu got directly hidden.

As far as I read the code, it seems that it's caused by this file & line :

sidebarContainer.style.top = (fold - currentScroll) + 'px';


I prefer asking before doing anything. Since it seems to be working with all of you guys, and the bug occurs only on my end. ( on both local & https://community.algolia.com/places )

@proudlygeek
Copy link
Contributor

I managed to reproduce the same issue (Chrome 50), it looks like there's some error in the left nav menu position computation. If it was working before I'd try to git revert or git bisect to find the culprit.

@LukyVj
Copy link
Member Author

LukyVj commented May 2, 2016

EDIT :
After a test by @proudlygeek, it seems he can also see the bug.

@LukyVj
Copy link
Member Author

LukyVj commented May 3, 2016

It seems that the property scrollHeight is not understood by all the browsers.

When it's not working, the line : const height = document.body.scrollHeight; is equal to 0
When it's working, the line is equal to 8951

@LukyVj
Copy link
Member Author

LukyVj commented May 3, 2016

So in the end, we're using this instead :
const height = document.querySelector('html').getBoundingClientRect().height;

So, it'll be fixed in the PR #148

@redox
Copy link
Contributor

redox commented May 3, 2016

Cool 👍

@redox redox closed this as completed May 3, 2016
vvo pushed a commit that referenced this issue May 11, 2016
# [0.23.0](v0.22.0...v0.23.0) (2016-05-11)

### Bug Fixes

* **documentation:** Fix sidebar scroll related to #145 (#148) ([a5ef82e](a5ef82e)), closes [#145](#145) [(#148](https://github.com/(/issues/148)
* **landing:** proper gifs parameters ([54ed9c5](54ed9c5))
* **style:false:** do not use .double.className ([3392d4a](3392d4a))
* **utm:** compute same utm as docsearch ([2cb1e54](2cb1e54))
* **UX:** highlight metadata also ([aa88262](aa88262)), closes [#157](#157)

### Features

* **documentation:** Clean css example ([428ef7a](428ef7a))
* **examples:** Making the examples squares clickable ([c1a1843](c1a1843))
* **webiste:** remove useless file ([39ace9e](39ace9e))
* **website:** New examples header and MISC optimization ([69c27ec](69c27ec))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants