Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

IE10 bug on placesAutocompleteDataset #385

Closed
chriscalip opened this issue Feb 8, 2017 · 3 comments · Fixed by #387
Closed

IE10 bug on placesAutocompleteDataset #385

chriscalip opened this issue Feb 8, 2017 · 3 comments · Fixed by #387

Comments

@chriscalip
Copy link

Bug Report on latest tag v1.4.9

Using browser IE10 and making use of placesAutocompleteDataset without input parameter language; which triggers
var language = _ref$language === undefined ? navigator.language.split('-')[0] : _ref$language;
This results in error for ie10 browser. Adding an input parameter resolves situation.

ie10-bug-places-lib
@vvo
Copy link
Contributor

vvo commented Feb 23, 2017

@chriscalip Did you find the reason for this? Thanks. Sorry I missed this ticket

@vvo vvo reopened this Feb 23, 2017
@chriscalip
Copy link
Author

@vvo Right bug is still in play. On my end since the workaround is so easy just add the language parameter .. so there's that. Yes bug is still in play.

vvo pushed a commit that referenced this issue Feb 27, 2017
fix(IE10): add navigatorLanguage polyfill in autocompleteDataset
b934d8f 
fixes #385
@vvo vvo mentioned this issue Feb 27, 2017
Merged
@vvo vvo closed this as completed in #387 Feb 27, 2017
@vvo
Copy link
Contributor

vvo commented Feb 27, 2017

should be fixed now, releasing places

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(IE10): add navigatorLanguage polyfill in autocompleteDataset algolia/places
2 participants
@vvo @chriscalip