Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

Invalid credentials #768

Merged
merged 5 commits into from
Apr 10, 2019
Merged

Invalid credentials #768

merged 5 commits into from
Apr 10, 2019

Conversation

raphi
Copy link
Contributor

@raphi raphi commented Apr 10, 2019

Display a clearer error message when the APP ID is invalid (not a Places app)

@raphi raphi requested a review from JonathanMontane April 10, 2019 08:15
src/errors.js Outdated Show resolved Hide resolved
src/places.js Outdated Show resolved Hide resolved
Copy link
Contributor

@JonathanMontane JonathanMontane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suggestion!
Overall LGTM 👍
I have a few suggestions to make this feature even better, if you want to have a look.

src/places.js Outdated Show resolved Hide resolved
Copy link
Contributor

@JonathanMontane JonathanMontane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@raphi raphi merged commit e68b1e8 into master Apr 10, 2019
@raphi raphi deleted the chore/invalid_credentials branch April 10, 2019 16:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants