feat: fast fail when sending no events (#532)

When the events payload is empty don't bother sending the request, fail fast.
algolia · May 22, 2024 · de26c37 · de26c37
1 parent fe023b5
commit de26c37
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/lib/__tests__/_sendEvent.test.ts b/lib/__tests__/_sendEvent.test.ts
@@ -737,6 +737,14 @@ describe("sendEvents", () => {
         }
       );
     });
+
+    it("should fail fast when sending no events via sendEvents", async () => {
+      const result = analyticsInstance.sendEvents([]);
+
+      expect(result).toBeInstanceOf(Promise);
+      expect(await result).toBe(false);
+      expect(fakeRequestFn).toHaveBeenCalledTimes(0);
+    });
   });
 
   it("applies default credentials when no custom ones are provided", () => {

diff --git a/lib/_sendEvent.ts b/lib/_sendEvent.ts
@@ -41,6 +41,10 @@ export function makeSendEvents(requestFn: RequestFnType) {
       return payload;
     });
 
+    if (events.length === 0) {
+      return Promise.resolve(false);
+    }
+
     return sendRequest(
       requestFn,
       this._ua,