Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add changelog #166

Merged
merged 3 commits into from
Sep 9, 2019
Merged

chore: add changelog #166

merged 3 commits into from
Sep 9, 2019

Conversation

eunjae-lee
Copy link
Contributor

@eunjae-lee eunjae-lee commented Sep 9, 2019

This PR adds CHANGELOG.md and a script to automatically update it.

yarn changelog will update the CHANGELOG.md file, considering the lastly released version (git tag).

yarn changelog will be added to the release process later.

Rendered CHANGELOG.md

@eunjae-lee eunjae-lee requested a review from tkrugg September 9, 2019 14:17
Copy link
Contributor

@tkrugg tkrugg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just remove everything about tests and other internal changes in the changelog, let me know if you need help figuring out what's the purpose of the change

package.json Outdated
@@ -50,6 +51,7 @@
"babel-preset-env": "1.7.0",
"body-parser": "1.19.0",
"bundlesize": "0.18.0",
"conventional-changelog-cli": "^2.0.23",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's pin this to follow the convention we follow on the other repos

@eunjae-lee eunjae-lee requested a review from tkrugg September 9, 2019 14:40
@eunjae-lee
Copy link
Contributor Author

I've updated the changelog. Let me know how you think about the change.

@eunjae-lee eunjae-lee merged commit bf20d1b into develop Sep 9, 2019
@eunjae-lee eunjae-lee deleted the chore/add-changelog branch September 9, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants