Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial code #1

Merged
merged 7 commits into from
Aug 10, 2022
Merged

Add initial code #1

merged 7 commits into from
Aug 10, 2022

Conversation

jasonpaulos
Copy link
Contributor

@jasonpaulos jasonpaulos commented Aug 8, 2022

Adds the initial implementation and testing code from go-algorand.

The initial commit of this PR contains the code as of algorand/go-algorand#4364

@jasonpaulos jasonpaulos marked this pull request as ready for review August 9, 2022 21:19
Copy link
Contributor

@michaeldiamant michaeldiamant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonpaulos I performed a cursory visual inspection and gained most confidence by inspecting downstream usage in algorand/go-algorand#4375.

jasonpaulos and others added 2 commits August 10, 2022 09:34
* Add golangci-lint

* Checkout code first

* Lint tests
* Make all txn types into variables

* Remove ParseArgJSONtoByteSlice

* Use '%w' for errors

* Remove no longer relevent comment

* Test VerifyMethodSignature

* Add documentation

* Make readme match docs

* Update docs package

* Update abi/doc.go

Co-authored-by: Michael Diamant <[email protected]>

Co-authored-by: Michael Diamant <[email protected]>
@jasonpaulos jasonpaulos merged commit d993539 into main Aug 10, 2022
@jasonpaulos jasonpaulos deleted the add-code branch August 10, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants