Adds box and parsing modules #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlgoStephenAkiki
force-pushed
the
1328-remove-logic-dependency
branch
from
3943708 to
4c2b1ee
Compare
Codecov Report
@@ Coverage Diff @@
## main #16 +/- ##
=======================================
Coverage 73.66% 73.66%
=======================================
Files 3 3
Lines 972 972
=======================================
Hits 716 716
Misses 182 182
Partials 74 74
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
For reviewer convenience:
|
michaeldiamant
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
@AlgoStephenAkiki Matches my understanding of what we intended to move. As a sanity check, I suggest holding for 1 more approval prior to merge to minimize need for issuing multiple releases.
Merged
jasonpaulos
reviewed
Jan 11, 2023
There was a problem hiding this comment.
Looks pretty good to me, but I think I'd prefer if the address functions were moved into their own package instead of being in the existing abi package.
I opened a child PR that does this, could you take a look? #17
* Create address package * Update function docs
jasonpaulos
approved these changes
Jan 12, 2023
winder
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.