Clean previously generated files before generation for generator_go.sh
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algochoi
changed the title
generator_go.sh
Co-authored-by: Michael Diamant <[email protected]>
michaeldiamant
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
@algochoi Thanks for figuring out a path forward for Go SDK!
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #46
This PR adds a line to the script to clean previously generated files. This will make sure that the generator generates up to date code and deletions in the API spec are reflected in the codebase as well.
Alternatively we considered moving hand-written files inside this repo (
generator), but it seems tricky to maintain versus keeping them inside the respective SDK repos.Tests
Go:
privatepaths, but we have since changed that) - see this diff: https://github.com/algorand/go-algorand-sdk/compare/delete-catchpoint-response?expand=1