Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: Delete langspec and templates #445

Merged
merged 6 commits into from
Dec 15, 2022

Conversation

algochoi
Copy link
Contributor

@algochoi algochoi commented Dec 9, 2022

This PR deletes langspec-related files and templates (templates rely on langspec functions).

Part of algorand/algorand-sdk-testing#223 and algorand/algorand-sdk-testing#254

@algochoi algochoi changed the title Delete langspec and templates v2: Delete langspec and templates Dec 9, 2022
@michaeldiamant michaeldiamant mentioned this pull request Dec 12, 2022
7 tasks
@algochoi algochoi changed the base branch from develop to feature/v2-breaking-changes December 13, 2022 17:12
@algochoi algochoi marked this pull request as ready for review December 14, 2022 16:54
@algochoi algochoi requested a review from ahangsu December 14, 2022 16:55
Copy link
Contributor

@ahangsu ahangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good, I am waiting on #450 being merged in + CHANGELOG breaking change note.

@algochoi algochoi merged commit 2b5ab2e into feature/v2-breaking-changes Dec 15, 2022
@algochoi algochoi deleted the remove-langspec branch December 15, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants