telemetry: add BlockAcceptedEventDetails.ReceivedAt to complement Val…

…idatedAt (#4583)

agreement/actions.go

@@ -236,6 +236,7 @@ func (a ensureAction) do(ctx context.Context, s *Service) {
 			Hash:         a.Certificate.Proposal.BlockDigest.String(),
 			Round:        uint64(a.Certificate.Round),
 			ValidatedAt:  a.Payload.validatedAt,
+			ReceivedAt:   a.Payload.receivedAt,
 			PreValidated: true,
 			PropBufLen:   uint64(len(s.demux.rawProposals)),
 			VoteBufLen:   uint64(len(s.demux.rawVotes)),
@@ -250,6 +251,7 @@ func (a ensureAction) do(ctx context.Context, s *Service) {
 			Hash:         a.Certificate.Proposal.BlockDigest.String(),
 			Round:        uint64(a.Certificate.Round),
 			ValidatedAt:  a.Payload.validatedAt,
+			ReceivedAt:   a.Payload.receivedAt,
 			PreValidated: false,
 			PropBufLen:   uint64(len(s.demux.rawProposals)),
 			VoteBufLen:   uint64(len(s.demux.rawVotes)),

agreement/demux.go

@@ -198,8 +198,11 @@ func (d *demux) next(s *Service, deadline time.Duration, fastDeadline time.Durat
 		proto, err := d.ledger.ConsensusVersion(ParamsRound(e.ConsensusRound()))
 		e = e.AttachConsensusVersion(ConsensusVersionView{Err: makeSerErr(err), Version: proto})
 
-		if e.t() == payloadVerified {
+		switch e.t() {
+		case payloadVerified:
 			e = e.(messageEvent).AttachValidatedAt(s.Clock.Since())
+		case payloadPresent:
+			e = e.(messageEvent).AttachReceivedAt(s.Clock.Since())
 		}
 	}()
 

agreement/events.go

@@ -938,3 +938,8 @@ func (e messageEvent) AttachValidatedAt(d time.Duration) messageEvent {
 	e.Input.Proposal.validatedAt = d
 	return e
 }
+
+func (e messageEvent) AttachReceivedAt(d time.Duration) messageEvent {
+	e.Input.Proposal.receivedAt = d
+	return e
+}

agreement/proposal.go

@@ -94,6 +94,11 @@ type proposal struct {
 	// validated (and thus was ready to be delivered to the state
 	// machine), relative to the zero of that round.
 	validatedAt time.Duration
+
+	// receivedAt indicates the time at which this proposal was
+	// delivered to the agreement package (as a messageEvent),
+	// relative to the zero of that round.
+	receivedAt time.Duration
 }
 
 func makeProposal(ve ValidatedBlock, pf crypto.VrfProof, origPer period, origProp basics.Address) proposal {

logging/telemetryspec/event.go

@@ -91,6 +91,7 @@ type BlockAcceptedEventDetails struct {
 	Hash         string
 	Round        uint64
 	ValidatedAt  time.Duration
+	ReceivedAt   time.Duration
 	PreValidated bool
 	PropBufLen   uint64
 	VoteBufLen   uint64