Simplify dryrunning and debugging group txn #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorandskiy
commented
Aug 15, 2020
| txns = append(txns, other...) | ||
| for i := range txns { | ||
| enc := protocol.EncodeJSON(&txns[i]) | ||
| dr.Txns = append(dr.Txns, enc) | ||
| } | ||
|
|
||
| if tx.Type == protocol.ApplicationCallTx { |
There was a problem hiding this comment.
entire if tx.Type == protocol.ApplicationCallTx { block moved inside the loop without modifications
algorandskiy
commented
Aug 15, 2020
Comment on lines
+941
to
+943
| if txnOrStxn == nil { | ||
| // empty input do nothing | ||
| } else if txn, ok := txnOrStxn.(transactions.Transaction); ok { |
There was a problem hiding this comment.
allow pre-existing groups of signed transactions
brianolson
reviewed
Aug 17, 2020
* Extend clerk dryrun so it can dump dryrun state object suitable for REST, tealdbg and python tests goal clerk dryrun -t grouptxn.msgp -o dr.mspg --dryrun-dump --dryrun-dump-format=msgp * Fix parameter validation in tealdbg * Fix NPE in REST dryrun when a first txn in a group non-TEAL
algorandskiy
force-pushed
the
pavel/goal
branch
from
7100707 to
2980e8f
Compare
tsachiherman
pushed a commit
to tsachiherman/go-algorand
that referenced
this pull request
Jul 7, 2021
Extend clerk dryrun so it can dump dryrun state object suitable for REST, tealdbg and python tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
goal clerk dryrun -t grouptxn.msgp -o dr.mspg --dryrun-dump --dryrun-dump-format=msgp
Test Plan
Extended expect test for group txn