Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for equal functions in teal.go #1486

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Add unit tests for equal functions in teal.go #1486

merged 1 commit into from
Sep 8, 2020

Conversation

algorandskiy
Copy link
Contributor

Summary

Added tests for EvalDelta.Equal and StateDelta.Equal

Test Plan

EvalDelta.Equal and StateDelta.Equal are 100% covered.

tsachiherman
tsachiherman suggested changes Sep 6, 2020
View reviewed changes
Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - two requests, which are basically the same one :
since both StateDelta and EvalDelta.GlobalDelta/EvalDelta.LocalDelta are maps, they could be a nil. We need to ensure that we test the use case where we compare a nil and an empty non-nil map.

@algorandskiy
Copy link
Contributor Author

Done

@tsachiherman tsachiherman merged commit 399078c into algorand:master Sep 8, 2020
@algorandskiy algorandskiy deleted the pavel/teal-equal-test branch October 9, 2020 19:02
tsachiherman pushed a commit to tsachiherman/go-algorand that referenced this pull request Jul 7, 2021
@algorandskiy
Add unit tests for equal functions in teal.go (algorand#1486)
19681d8 
Add unit tests for equal functions in teal.go
@yaovi-a yaovi-a mentioned this pull request Aug 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsachiherman tsachiherman tsachiherman approved these changes

@algomaxj algomaxj Awaiting requested review from algomaxj

Assignees

@algorandskiy algorandskiy

Labels
Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@algorandskiy @tsachiherman