Fix build_status path in packaging #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onetechnical
previously approved these changes
Oct 29, 2020
btoll
reviewed
Oct 29, 2020
egieseke
reviewed
Oct 29, 2020
btoll
previously approved these changes
Oct 29, 2020
onetechnical
dismissed stale reviews from egieseke and btoll
The base branch was changed.
btoll
previously approved these changes
Oct 29, 2020
btoll
dismissed
their stale review
Didn't see that there was a problem with changing branches.
PKG_DIR was getting set in this script prior to the loop that iterates over all os/arch builds. This was causing the build_status files to be placed into incorrect directories. I fixed this and removed the redundent OUTPUT_DIR var
bricerisingalgorand
force-pushed
the
brice/fixPackageBuildStatus
branch
from
4ff4475 to
20156da
Compare
onetechnical
approved these changes
Oct 29, 2020
btoll
approved these changes
Oct 29, 2020
egieseke
approved these changes
Oct 29, 2020
tsachiherman
pushed a commit
to tsachiherman/go-algorand
that referenced
this pull request
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I missed a variable that needed to be added to the loop that packages all of our linux artifacts. This change places the file in the correct directory
Test Plan
I ran a build/package and saw that it's not in the correct path