Brice/fix blockers #1673
Merged
Brice/fix blockers #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- RPM/arch issue when installing yum - Missing genesisfiles for tarballs - missing algorand-devtools-beta package
btoll
reviewed
Oct 30, 2020
| -e "s,@REQUIRED_ALGORAND_PKG@,$REQUIRED_ALGORAND_PACKAGE," \ | ||
| > "$TEMPDIR/$ALGORAND_PACKAGE_NAME.spec" | ||
|
|
||
| rpmbuild --buildroot "$HOME/foo" --define "_rpmdir $RPMTMP" --define "RELEASE_GENESIS_PROCESS x$RELEASE_GENESIS_PROCESS" --define "LICENSE_FILE ./COPYING" -bb "$TEMPDIR/$ALGORAND_PACKAGE_NAME.spec" --target $ARCH_TYPE | ||
| rpmbuild --buildroot "$HOME/foo" --define "_rpmdir $RPMTMP" --define "RELEASE_GENESIS_PROCESS x$RELEASE_GENESIS_PROCESS" --define "LICENSE_FILE ./COPYING" -bb "$TEMPDIR/$ALGORAND_PACKAGE_NAME.spec" --target $ARCH_UNAME |
There was a problem hiding this comment.
I think we should remove this:
--define "RELEASE_GENESIS_PROCESS x$RELEASE_GENESIS_PROCESS"
Then the rpm package will get all the genesis dirs.
onetechnical
approved these changes
Oct 30, 2020
tsachiherman
pushed a commit
to tsachiherman/go-algorand
that referenced
this pull request
Jul 7, 2021
Fix issues that came up during betanet release - RPM/arch issue when installing yum - Missing genesisfiles for tarballs - missing algorand-devtools-beta package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found these blocking issues while performing a betanet release:
RPM/arch issue when installing yum
Missing genesisfiles for tarballs
missing algorand-devtools-beta package
We updated the yum packages to use the uname style names for cpu architectures, updated our build_packages script to always bundle all long lived network genesis files, and fixed an issue in the rpm packaging scripts so that the devtools package will contain the channel of the build
These were all tested locally by performing the same build our pipeline does