Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better 'goal asset' help documentation. #1687

Merged
merged 2 commits into from
Nov 10, 2020

Conversation

winder
Copy link
Contributor

@winder winder commented Nov 6, 2020

Fix some goal asset documentation

tsachiherman
tsachiherman previously approved these changes Nov 6, 2020
Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.
I'm not sure if grammatically it's correct. Shouldn't it be asset's tokens ? ( i.e. possessive , https://www.thepunctuationguide.com/apostrophe.html )

ryanRfox
ryanRfox previously approved these changes Nov 6, 2020
@winder winder added this to the Sprint 12 milestone Nov 10, 2020
Copy link
Contributor

@ryanRfox ryanRfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsachiherman tsachiherman merged commit 75d289a into algorand:master Nov 10, 2020
tsachiherman pushed a commit to tsachiherman/go-algorand that referenced this pull request Jul 7, 2021
Better 'goal asset' help documentation
@winder winder deleted the will/doc-update branch July 12, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants