Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run gofmt against source code. #1797

Merged
merged 2 commits into from
Dec 30, 2020
Merged

Run gofmt against source code. #1797

merged 2 commits into from
Dec 30, 2020

Conversation

tsachiherman
Copy link
Contributor

Summary

The changes in this PR are the result of running :

go list ./... | xargs -I % gofmt -s -w ../../../%

These changes eliminates the warning appear in the vscode editor.

Test Plan

No tests are needed; This is only code style change.

@tsachiherman tsachiherman marked this pull request as ready for review December 30, 2020 00:13
@tsachiherman tsachiherman self-assigned this Dec 30, 2020
brianolson
brianolson approved these changes Dec 30, 2020
View reviewed changes
Copy link
Contributor

@brianolson brianolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What version of Go tools are you using? This seems to be a lot of sites of the recurring theme of not needing an array element to be typed with the type of the array. Did go fmt get upgraded?

@tsachiherman
Copy link
Contributor Author

tsachiherman commented Dec 30, 2020 •
edited
Loading

What version of Go tools are you using? This seems to be a lot of sites of the recurring theme of not needing an array element to be typed with the type of the array. Did go fmt get upgraded?

gofmt has more options compared to go fmt; The -s is one of them. I'm using go 1.14.7.
If you'll look in the documentation, go fmt would invoke the gofmt -l -w.

algonautshant
algonautshant approved these changes Dec 30, 2020
View reviewed changes
Copy link
Contributor

@algonautshant algonautshant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@tsachiherman tsachiherman merged commit 693b673 into algorand:master Dec 30, 2020
@tsachiherman tsachiherman deleted the tsachi/govet branch December 30, 2020 17:50
tsachiherman added a commit to tsachiherman/go-algorand that referenced this pull request Jul 7, 2021
@tsachiherman
Run gofmt against source code (algorand#1797)
5ce94e3 
Run gofmt against source code, and update coding style.
PhearZero pushed a commit to PhearNet/crypto that referenced this pull request Jan 17, 2025
@tsachiherman
Run gofmt against source code (algorand#1797)
5f7a484 
Run gofmt against source code, and update coding style.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianolson brianolson brianolson approved these changes

@algonautshant algonautshant algonautshant approved these changes

Assignees

@tsachiherman tsachiherman

Labels
Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsachiherman @brianolson @algonautshant