Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollback config v17 into v16 #2140

Merged
merged 1 commit into from
May 7, 2021

Conversation

tsachiherman
Copy link
Contributor

Summary

Previous PRs were advancing the config version from v16 to v17 needlessly.
( i.e. needlessly since the rel/beta is currently at v15 )

This PR merges back the changes from v17 into v16, and removes v17.

Test Plan

Use existing unit tests.

Copy link
Contributor

@algonautshant algonautshant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
I was wondering why it was advanced to 17.

@tsachiherman tsachiherman merged commit c0452b2 into algorand:master May 7, 2021
@tsachiherman tsachiherman deleted the tsachi/rollbackv17 branch May 7, 2021 19:10
tsachiherman added a commit to tsachiherman/go-algorand that referenced this pull request Jul 7, 2021
Previous PRs were advancing the config version from v16 to v17 needlessly.
( i.e. needlessly since the rel/beta is currently at v15 )

This PR merges back the changes from v17 into v16, and removes v17.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants