Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remerge v2.5.6-stable #2141

Merged
merged 18 commits into from
May 7, 2021
Merged

remerge v2.5.6-stable #2141

merged 18 commits into from
May 7, 2021

Conversation

onetechnical
Copy link
Contributor

@onetechnical onetechnical commented May 7, 2021

Summary

Finishing re-merge of v2.5.6-stable release.

Test Plan

Standard integration testing. Changes should commits only, no file changes.

tsachiherman and others added 18 commits April 16, 2021 12:32
Rollback #1756, as it was determined to cause proposal propagation issues.
This rollback would take the original work back onto the research stage, and would allow us to provide better testing before re-applying it.
Ensure local delta does not have entries with empty key-value stores
Fix for empty accounts stored in DB after app clear state or app removal
Delete empty entries, update merkleTrie hashes.
Improve error test conditions during database migration 4.
Fix accessing int64 atomic variables on arm32, by aligning variables on 64-bit aligned address.
#2095)

roundCowState now has compatibility mode
accountIdx param is propagated from logic to GetKey/SetKey/DelKey
Logic:
- store account index for used in GetKey for this app
- in SetKey/DelKey use store either the index from GetKey if exist or a current account index
- if in compatibility mode, BuildEvalDelta uses indices mentioned above otherwise it calculates account index using `txn.Accounts`
@algobarb
Copy link
Contributor

algobarb commented May 7, 2021

Why do we do this if files don't change? Is it to keep the commit history or something?

@onetechnical
Copy link
Contributor Author

Why do we do this if files don't change? Is it to keep the commit history or something?

Yes. It ensures that the branches do not diverge and share a lineage. If there are fixes downstream, they may also be captured here, though that is less common.

@algojohnlee algojohnlee merged commit 4975b21 into algorand:master May 7, 2021
tsachiherman pushed a commit to tsachiherman/go-algorand that referenced this pull request Jul 7, 2021
@onetechnical onetechnical deleted the onetechnical/remerge-2-5-6 branch August 3, 2021 12:23
PhearZero pushed a commit to PhearNet/crypto that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants