txpool: Fix incorrect datatype checking in recomputeBlockEvaluator #2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algonautshant
approved these changes
May 14, 2021
| @@ -695,7 +695,7 @@ func (pool *TransactionPool) recomputeBlockEvaluator(committedTxIds map[transact | |||
| } | |||
|
|
|||
| switch err.(type) { | |||
| case ledgercore.TransactionInLedgerError: | |||
| case *ledgercore.TransactionInLedgerError: | |||
There was a problem hiding this comment.
This looks confusing, and can be mistaken somewhere else.
Why not return the error by value, and make the Txid inside it a pointer, if copying it is a concern?
type TransactionInLedgerError struct {
Txid *transactions.Txid
}
There was a problem hiding this comment.
I agree. We clearly need to figure this out. However, as you've noted, it could be a sensitive issue where fixing it incorrectly could lead to other issues. That's why I opted in for the simple fix.
tsachiherman
added a commit
to tsachiherman/go-algorand
that referenced
this pull request
Jul 7, 2021
) When the recomputeBlockEvaluator runs, it tests all the pending transactions against the ledger to detect duplicate transactions ( which happen all the time; these aren't an issue ). The block evaluator reports the error by returning `*ledgercore.TransactionInLedgerError` and not `ledgercore.TransactionInLedgerError` as the code was testing against.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the recomputeBlockEvaluator runs, it tests all the pending transactions against the ledger to detect duplicate transactions ( which happen all the time; these aren't an issue ).
The block evaluator reports the error by returning
*ledgercore.TransactionInLedgerErrorand notledgercore.TransactionInLedgerErroras the code was testing against.Note
Yet another one character bug fix.
Test Plan
The bug would only affect the reported block assembly stats, and therefore the issue was validated against the telemetry.