-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for RHEL Centos 8 RPM #2190
Changes from 15 commits
fde81a5
6a1473b
9be50ea
6b13ca8
bae59e4
c73046e
436d6b4
a51d23f
60b49e0
81fe6fb
fb5cf8e
b309c83
780a944
e864ee7
98e95f7
2424983
9361c2d
bc7b3f8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
ARG ARCH="amd64" | ||
|
||
FROM ${ARCH}/centos:8 | ||
ARG GOLANG_VERSION | ||
ARG ARCH="amd64" | ||
RUN yum install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-8.noarch.rpm && \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do we There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it shouldn't actually make a difference, but it wouldn't hurt to switch to dnf There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Replaced use of yum with dnf. |
||
yum update -y && \ | ||
yum install -y autoconf wget awscli git gnupg2 nfs-utils python3-devel boost-devel expect jq \ | ||
libtool gcc-c++ libstdc++-devel rpmdevtools createrepo rpm-sign bzip2 which \ | ||
libffi-devel openssl-devel | ||
RUN dnf install -y epel-release && \ | ||
dnf update && \ | ||
dnf -y install sqlite && \ | ||
dnf -y --enablerepo=powertools install libstdc++-static && \ | ||
dnf -y install make | ||
RUN echo "${BOLD}Downloading and installing binaries...${RESET}" && \ | ||
curl -Of https://shellcheck.storage.googleapis.com/shellcheck-v0.7.0.linux.x86_64.tar.xz && \ | ||
tar -C /usr/local/bin/ -xf shellcheck-v0.7.0.linux.x86_64.tar.xz --no-anchored 'shellcheck' --strip=1 | ||
WORKDIR /root | ||
RUN wget https://dl.google.com/go/go${GOLANG_VERSION}.linux-${ARCH%v*}.tar.gz \ | ||
&& tar -xvf go${GOLANG_VERSION}.linux-${ARCH%v*}.tar.gz && \ | ||
mv go /usr/local | ||
ENV GOROOT=/usr/local/go \ | ||
GOPATH=$HOME/go \ | ||
ARCH_TYPE=${ARCH} | ||
RUN mkdir -p $GOPATH/src/github.com/algorand | ||
COPY . $GOPATH/src/github.com/algorand/go-algorand | ||
ENV PATH=$GOPATH/bin:$GOROOT/bin:$PATH \ | ||
GOPROXY=https://proxy.golang.org,https://pkg.go.dev,https://goproxy.io,direct | ||
WORKDIR $GOPATH/src/github.com/algorand/go-algorand | ||
RUN make clean | ||
RUN rm -rf $GOPATH/src/github.com/algorand/go-algorand && \ | ||
mkdir -p $GOPATH/src/github.com/algorand/go-algorand | ||
RUN echo "vm.max_map_count = 262144" >> /etc/sysctl.conf | ||
CMD ["/bin/bash"] |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,6 +21,17 @@ agents: | |
- VERSION=$VERSION | ||
workDir: $HOME/projects/go-algorand | ||
|
||
- name: rpm.centos8 | ||
dockerFilePath: docker/build/cicd.centos8.Dockerfile | ||
image: algorand/go-algorand-ci-linux-centos8 | ||
version: scripts/configure_dev-deps.sh | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. does this file still exist? I thought tsachi was removing it There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I cleared it's content, but kept it around so it won't create build failures. |
||
buildArgs: | ||
- GOLANG_VERSION=`./scripts/get_golang_version.sh` | ||
env: | ||
- NETWORK=$NETWORK | ||
- VERSION=$VERSION | ||
workDir: $HOME/projects/go-algorand | ||
|
||
- name: docker | ||
dockerFilePath: docker/build/docker.ubuntu.Dockerfile | ||
image: algorand/go-algorand-docker-linux-ubuntu | ||
|
@@ -45,6 +56,11 @@ tasks: | |
agent: rpm | ||
target: mule-package-rpm | ||
|
||
- task: docker.Make | ||
name: rpm.centos8 | ||
agent: rpm.centos8 | ||
target: mule-package-rpm.centos8 | ||
|
||
- task: docker.Make | ||
name: deb | ||
agent: deb | ||
|
@@ -61,6 +77,7 @@ jobs: | |
- docker.Make.build | ||
- docker.Make.deb | ||
- docker.Make.rpm | ||
- docker.Make.rpm.centos8 | ||
- docker.Make.docker | ||
|
||
package-deb: | ||
|
@@ -71,6 +88,7 @@ jobs: | |
tasks: | ||
- docker.Make.build | ||
- docker.Make.rpm | ||
- docker.Make.rpm.centos8 | ||
|
||
package-docker: | ||
tasks: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
FROM centos:8 | ||
|
||
WORKDIR /root | ||
RUN yum install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-8.noarch.rpm | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here, should we dnf everywhere? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated to use dnf. |
||
RUN yum install -y autoconf awscli curl git gnupg2 nfs-utils python36 sqlite3 boost-devel expect jq libtool gcc-c++ libstdc++-devel libstdc++-static rpmdevtools createrepo rpm-sign bzip2 which ShellCheck | ||
|
||
ENTRYPOINT ["/bin/bash"] | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -105,6 +105,7 @@ fi | |
|
||
sudo usermod -a -G docker ubuntu | ||
sg docker "docker pull centos:7" | ||
sg docker "docker pull centos:8" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Might want to replace this with the stream image, but not really a blocker. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated to pull quay.io/centos/centos:stream8. |
||
sg docker "docker pull ubuntu:18.04" | ||
|
||
cat << EOF >> "${HOME}/.bashrc" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
@Library('go-algorand-ci') _ | ||
@Library('go-algorand-ci@update-cicd-cachename') _ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't forget to update this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed branch. |
||
|
||
muleCI('test/muleCI/mule.yaml', '0.0.12') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine, but I'm curious if there's a more supported stream image, e.g.:
quay.io/centos/centos:stream8
I don't actually know if that would be better or worse. ¯_(ツ)_/¯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh right, i thought we were going to use that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to pull from quay.io/centos/centos:stream8.