Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batch verification #2578

Merged
merged 23 commits into from
Aug 7, 2021
Merged

Conversation

id-ms
Copy link
Contributor

@id-ms id-ms commented Jul 18, 2021

Summary

Test Plan

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2021

Codecov Report

Merging #2578 (437ca32) into master (39be0c7) will increase coverage by 0.00%.
The diff coverage is 57.28%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2578   +/-   ##
=======================================
  Coverage   47.07%   47.07%           
=======================================
  Files         349      350    +1     
  Lines       55858    55925   +67     
=======================================
+ Hits        26294    26327   +33     
- Misses      26617    26646   +29     
- Partials     2947     2952    +5     
Impacted Files Coverage Δ
crypto/multisig.go 45.34% <38.23%> (+9.15%) ⬆️
data/transactions/verify/txn.go 45.08% <43.90%> (-3.37%) ⬇️
crypto/batchverifier.go 100.00% <100.00%> (ø)
ledger/blockqueue.go 82.18% <0.00%> (-2.88%) ⬇️
network/wsPeer.go 72.14% <0.00%> (-2.23%) ⬇️
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
ledger/acctupdates.go 62.05% <0.00%> (-0.26%) ⬇️
cmd/tealdbg/debugger.go 73.86% <0.00%> (+1.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39be0c7...437ca32. Read the comment docs.

@id-ms id-ms requested a review from algonathan July 18, 2021 10:13
Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. two minor comments, but neither of them would be a blocker.

Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments, but looks good otherwise!

@tsachiherman tsachiherman merged commit 9194dec into algorand:master Aug 7, 2021
PhearZero pushed a commit to PhearNet/crypto that referenced this pull request Jan 17, 2025
Add the framework for supporting batch verification.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants