CircleCI: parameterizing no_output_timeout and -short #2618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algobarb
requested review from
bricerisingalgorand,
algojack,
egieseke and
onetechnical
Codecov Report
@@ Coverage Diff @@
## master #2618 +/- ##
==========================================
- Coverage 46.98% 46.97% -0.01%
==========================================
Files 348 348
Lines 55717 55717
==========================================
- Hits 26179 26174 -5
- Misses 26594 26601 +7
+ Partials 2944 2942 -2
Continue to review full report at Codecov.
|
algobarb
changed the title
algojack
reviewed
Jul 27, 2021
algojack
approved these changes
Jul 27, 2021
egieseke
approved these changes
Jul 27, 2021
| default: "/home/circleci" | ||
| result_subdir: | ||
| default: 30m | ||
| short_test_flag: |
There was a problem hiding this comment.
I wonder if this could be made more generic to support any test flag?
There was a problem hiding this comment.
I'm not sure I want to do that anymore:
- We're calling a bunch of other parameters inside the test itself right now, so it could be confusing to add an any_test flag because you can't add whatever parameter you want. Only parameters that haven't been specified yet
-shortis the main flag we're using and it helps to repeat the same variable name used in generic_integration for consistency- Will mentioned that he wants us to stop calling gotestsum directly in the file eventually, so I expect further modifications on this command. (1426 in our CircleCI epic)
algobarb
changed the title
algojack
pushed a commit
that referenced
this pull request
Jul 29, 2021
Parameterize no_output_timeout and -short in the general commands on the circle config file to reduce duplicate code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Parameterize no_output_timeout and -short in the general commands on the circle config file to reduce duplicate code.
I did also increase the size of integration tests to large as I saw that we had errors in mac_amd64_integration, arm64_integration and arm64_integration recently but would run after manually rerunning from failure.
Test Plan
Tested it on a Pull request that would run the nightly and then tested the regular short tests once.