replace the KMD usage in pingpong with direct signing #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still should have local storage for generated accounts |
shared/pingpong/pingpong.go
Outdated
| @@ -208,12 +220,12 @@ func fundAccounts(accounts map[string]uint64, client libgoal.Client, cfg PpConfi | |||
| } | |||
|
|
|||
| fmt.Printf("adjusting account balance to %d\n", minFund) | |||
| for addr, balance := range accounts { | |||
| for addr, val := range accounts { | |||
shared/pingpong/pingpong.go
Outdated
| cfg PpConfig | ||
| accounts map[string]uint64 | ||
| cfg PpConfig | ||
| //accounts map[string]uint64 |
There was a problem hiding this comment.
drop commented out lines.
shared/pingpong/pingpong.go
Outdated
| return | ||
| } | ||
|
|
||
| psig = accounts[signer].sk.Sign(logic.Program(cfg.Program)) |
There was a problem hiding this comment.
I could be wrong, but I think that you might want to do
progb := logic.Program(cfg.Program)
psig = accounts[signer].sk.Sign(&progb)
tsachiherman
suggested changes
Jul 28, 2021
Codecov Report
@@ Coverage Diff @@
## master #2653 +/- ##
==========================================
+ Coverage 47.04% 47.05% +0.01%
==========================================
Files 349 349
Lines 55814 55814
==========================================
+ Hits 26256 26262 +6
+ Misses 26608 26605 -3
+ Partials 2950 2947 -3
Continue to review full report at Codecov.
|
tsachiherman
changed the title
tsachiherman
added a commit
that referenced
this pull request
Aug 4, 2021
This reverts commit 8835bfd.
tsachiherman
added a commit
that referenced
this pull request
Aug 5, 2021
This was referenced Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes signing calls to KMD by creating internal hashmap and signing transactions locally.
Resolves #2644
Test Plan
Tested using performance system.