Checking CircleCI tests run once and only once #2749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2749 +/- ##
==========================================
- Coverage 47.14% 47.11% -0.04%
==========================================
Files 349 349
Lines 56430 56430
==========================================
- Hits 26606 26588 -18
- Misses 26845 26861 +16
- Partials 2979 2981 +2
Continue to review full report at Codecov.
|
algojack
force-pushed
the
jack/1489-checking-circleci-tests-run-only-once
branch
from
c952d98 to
68e791c
Compare
algojack
force-pushed
the
jack/1489-checking-circleci-tests-run-only-once
branch
from
a5d4058 to
12bb942
Compare
…circleci-tests-run-only-once
|
OK, I pushed the revert of 11d153a to undo the double-sharding skips that intentionally introduced. |
|
once i clean up normal tests, i will switch to nightlies and clean up nightlies too, before switching back to normal. |
…hub.com:algorand/go-algorand into jack/1489-checking-circleci-tests-run-only-once
cce
reviewed
Sep 7, 2021
cce
previously approved these changes
Sep 7, 2021
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
cce
approved these changes
Sep 8, 2021
algojack
changed the title
algobarb
reviewed
Sep 8, 2021
algobarb
approved these changes
Sep 8, 2021
algojohnlee
deleted the
jack/1489-checking-circleci-tests-run-only-once
branch
Merged
algojohnlee
pushed a commit
that referenced
this pull request
Sep 16, 2021
Based on the matrix job @algojack added in #2749, this turns the other per-platform jobs into matrix jobs too. The most significant change in this PR is switching from building in the home directory (/home/circleci on Linux and /Users/distiller on Mac) to instead build out of /opt/cibuild to make it easier for the matrix jobs to share configuration.
PhearZero
pushed a commit
to PhearNet/crypto
that referenced
this pull request
Jan 17, 2025
Our partitioned tests might be skipping tests or running them twice. Here we want to make sure they don't do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our partitioned tests might be skipping tests or running them twice. Here we want to make sure they don't do that.
Test Plan
Testing in CircleCI on this branch before merging to master