Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix goalNodeTest.exp #2781

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Fix goalNodeTest.exp #2781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/e2e-go/cli/goal/expect/goalAccountTest.exp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ if { [catch {
# Determine primary account
set PRIMARY_ACCOUNT_ADDRESS [::AlgorandGoal::GetHighestFundedAccountForWallet $PRIMARY_WALLET_NAME $TEST_PRIMARY_NODE_DIR]

set timeout 30

# try to generate an expired transaction for 5 times before giving up.
set TEST_TRANSACTION_EXPIRATION 5
while {$TEST_TRANSACTION_EXPIRATION > 0} {
Expand Down
1 change: 1 addition & 0 deletions test/e2e-go/cli/goal/expect/goalClerkGroupTest.exp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ if { [catch {
# Determine primary account
set PRIMARY_ACCOUNT_ADDRESS [::AlgorandGoal::GetHighestFundedAccountForWallet $PRIMARY_WALLET_NAME $TEST_PRIMARY_NODE_DIR]

set timeout 30
set FEE_AMOUNT 1000

set TXN_FILE1 "$TEST_PRIMARY_NODE_DIR/txns1"
Expand Down
2 changes: 1 addition & 1 deletion test/e2e-go/cli/goal/expect/goalNodeTest.exp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ if { [catch {
spawn goal node start -d $TEST_PRIMARY_NODE_DIR
expect {
timeout { close; ::AlgorandGoal::Abort "starting node exceeded timeout" }
-re {^Algorand node failed to start: node exited with an error code, check node\.log for more details : exit status 1} {
-re {^Algorand node failed to start: node exited with an error code, check node\.log for more details : exit status \d+} {
puts "\nExpected failuire : node failed to start"
# wait until the eof signal is received
expect {
Expand Down
13 changes: 7 additions & 6 deletions test/framework/fixtures/expectFixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package fixtures

import (
"bytes"
"fmt"
"io/ioutil"
"os"
"os/exec"
Expand Down Expand Up @@ -113,16 +114,16 @@ func MakeExpectTest(t *testing.T) *ExpectFixture {

// Run Process all expect script files with suffix Test.exp within the current directory
func (ef *ExpectFixture) Run() {
disabledTest := map[string]bool{
"pingpongTest.exp": true,
disabledTest := map[string]string{
"pingpongTest.exp": "broken",
"listExpiredParticipationKeyTest.exp": "flaky",
}
for testName := range ef.expectFiles {
if match, _ := regexp.MatchString(ef.testFilter, testName); match {
if disabledTest[testName] {
continue
}

ef.t.Run(testName, func(t *testing.T) {
if reason, ok := disabledTest[testName]; ok {
t.Skip(fmt.Sprintf("Skipping %s test: %s", testName, reason))
}
partitiontest.PartitionTest(t) // Check if this expect test should by run, may SKIP

syncTest := SynchronizedTest(t)
Expand Down