-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing golang version to 1.16.11 in go-algorand #2825
Merged
algojohnlee
merged 18 commits into
algorand:master
from
algojack:jack/upgrade-golang-version-to-1.16.7
Dec 8, 2021
Merged
Changes from 2 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
6275be1
Changing golang version to 1.16.7 everywhere
algojack 5393716
Ran go mod tidy to clean up unsused packages
algojack 0fae3e5
Removed GO111MODULE=on since it's now on by default
algojack 5f5971a
Merge branch 'master' into jack/upgrade-golang-version-to-1.16.7
algojack 0793877
Update e2e_go_tests.sh
algojack 904f7ee
Update go.sum
algojack a030f4a
Update reviewdog.yml
algojack fdd85ee
Update config.yml
algojack b704f5c
Update get_golang_version.sh
algojack 26d6e4e
Merge branch 'master' into jack/upgrade-golang-version-to-1.16.7
algojack c4112bf
Merge branch 'master' into jack/upgrade-golang-version-to-1.16.7
algojack 18ff8b6
Ran go mod tidy
algojack 6232b71
Upgrading to 1.16.10
algojack 32b0b38
Merge branch 'master' into jack/upgrade-golang-version-to-1.16.7
algojack 6c39870
Merge branch 'master' into jack/upgrade-golang-version-to-1.16.7
algojack d8cbbea
Update config.yml
algojack 31a9e6d
Update reviewdog.yml
algojack a868f69
Update get_golang_version.sh
algojack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
GO111MODULEneeded withgo install?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it used to be required before go 1.12. I'm not sure if its still applies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was auto (built in 1.13+ if go.mod was present) but as of 1.16 it defaults to on. We should probably remove setting it explicitly here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It defaults to on now, but it doesn't hurt to leave it on and might help developers a little behind in keeping their environment up to date. I'd be fine with deleting this in another 6 months or so. It would be nice if
makereported a warning "Please upgrade your golang to 1.16 or greater".There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, removed all references to GO111MODULE=on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To Brian's comment: I think it's okay to set our minimum version for support higher. I believe we call
scripts/check_golang_version.shand explicitly tell people to upgrade, if they run configure_dev.sh.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like GO111MODULE defaulting to on is linked to GOPATH being deprecated: golang/go#41330
I think it would be a good idea to leave
GO111MODULE=onuntil we completely removeGOPATHThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refinement on GOPATH from that golang issue since I was confused and had to read up on it:
$GOPATH/src is going away as a source organization strategy, replaced by modules (and their 99% invisible cache structure inside $GOPATH/pkg). Any build assumption about
go-algorand/being at$GOPATH/src/github.com/algorand/go-algorand/should really really go away (I'm pretty sure it's gone from build but it lingered in integration tests for a while).$GOPATH/bin is sticking around as the output directory for
go installThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification Brian. I would guess setting 1.16 in the
go.modfile would force people to upgrade regardless ofscripts/check_golang_version.sh, so removing all references toGO111MODULE=onshould be fine.