-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loads and stores opcodes that take scratch slot from stack #2853
Conversation
f85bba3
to
f81d0a7
Compare
f81d0a7
to
b465587
Compare
Codecov Report
@@ Coverage Diff @@
## master #2853 +/- ##
==========================================
+ Coverage 47.28% 47.30% +0.02%
==========================================
Files 351 351
Lines 56488 56505 +17
==========================================
+ Hits 26708 26730 +22
- Misses 26765 26768 +3
+ Partials 3015 3007 -8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me. Had one comment about naming. Thanks for fixing the txnas
related parts 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Lots of fixups for not checking unit64 to int casts as well.