Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change import paths used in crypto/secp256k1/dummy.go #2881

Merged
merged 2 commits into from
Sep 14, 2021

Conversation

cce
Copy link
Contributor

@cce cce commented Sep 13, 2021

Summary

Since the merge of #2852 go mod tidy and go mod vendor see paths in github.com/ethereum/go-ethereum/crypto/secp256k1/libsecp256k1 as a dependency, and go mod tidy adds it to go.mod.

Test Plan

All tests should pass as before.

@cce cce requested a review from algorandskiy September 13, 2021 20:48
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2021

Codecov Report

Merging #2881 (aab9db1) into master (08d31fa) will decrease coverage by 3.77%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2881      +/-   ##
==========================================
- Coverage   47.00%   43.23%   -3.78%     
==========================================
  Files         355      355              
  Lines       57195    57195              
==========================================
- Hits        26884    24726    -2158     
- Misses      27239    29479    +2240     
+ Partials     3072     2990      -82     
Impacted Files Coverage Δ
crypto/merklearray/worker.go 0.00% <0.00%> (-100.00%) ⬇️
crypto/compactcert/structs.go 0.00% <0.00%> (-100.00%) ⬇️
agreement/agreementtest/keyManager.go 0.00% <0.00%> (-100.00%) ⬇️
daemon/algod/api/server/lib/middlewares/auth.go 0.00% <0.00%> (-100.00%) ⬇️
agreement/agreementtest/simulate.go 0.00% <0.00%> (-87.68%) ⬇️
cmd/algofix/deadlock.go 3.12% <0.00%> (-84.38%) ⬇️
crypto/merklearray/partial.go 0.00% <0.00%> (-84.10%) ⬇️
ledger/onlineacct.go 17.64% <0.00%> (-82.36%) ⬇️
crypto/onetimesig.go 0.00% <0.00%> (-76.28%) ⬇️
data/account/rootInstall.go 0.00% <0.00%> (-75.00%) ⬇️
... and 93 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08d31fa...aab9db1. Read the comment docs.

@algojohnlee algojohnlee merged commit bbe8865 into algorand:master Sep 14, 2021
@cce cce deleted the fix-go-mod-secp256k1 branch September 15, 2021 15:01
PhearZero pushed a commit to PhearNet/crypto that referenced this pull request Jan 17, 2025
Since the merge of algorand#2852 go mod tidy and go mod vendor see paths in github.com/ethereum/go-ethereum/crypto/secp256k1/libsecp256k1 as a dependency, and go mod tidy adds it to go.mod.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants