Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Falcon key gen time: set LastPartKeyRound 3K #3280

Conversation

algonautshant
Copy link
Contributor

@algonautshant algonautshant commented Dec 6, 2021

  • remove test param from CreateNetworkFromTemplate

  • Do not override template.Genesis.LastPartKeyRound if in test mode or if ALGOTEST env variable is set

  • update test templates to explicitly set the LastPartKeyRound to 3k instead of relying on 3M default value.

  • Flag to cap last round of participation key generation, and use the flag for testing.

  • Enhance notification messages to notify the user the keys are generated.

  • Reduce LastPartKeyRound for scenarios 1-3.

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2021

Codecov Report

Merging #3280 (a4f14ec) into feature/dilithium-scheme-integration (ca330c6) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                           Coverage Diff                            @@
##           feature/dilithium-scheme-integration    #3280      +/-   ##
========================================================================
- Coverage                                 47.84%   47.82%   -0.03%     
========================================================================
  Files                                       381      381              
  Lines                                     61651    61651              
========================================================================
- Hits                                      29496    29483      -13     
- Misses                                    28734    28741       +7     
- Partials                                   3421     3427       +6     
Impacted Files Coverage Δ
cmd/goal/network.go 16.48% <0.00%> (ø)
gen/generate.go 14.15% <0.00%> (-0.20%) ⬇️
netdeploy/network.go 9.09% <ø> (+0.12%) ⬆️
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
ledger/blockqueue.go 82.18% <0.00%> (-2.88%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
cmd/tealdbg/debugger.go 72.86% <0.00%> (-1.01%) ⬇️
ledger/acctupdates.go 65.01% <0.00%> (-0.96%) ⬇️
network/wsNetwork.go 63.04% <0.00%> (-0.20%) ⬇️
catchup/service.go 69.90% <0.00%> (+0.49%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca330c6...a4f14ec. Read the comment docs.

@algonautshant algonautshant changed the title Shant/last part key round Falcon key gen time: set LastPartKeyRound 3K Dec 9, 2021
Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is LastPartKeyRound in the template new?

@algonautshant algonautshant self-assigned this Dec 19, 2021
@id-ms id-ms closed this Jan 2, 2022
@id-ms id-ms reopened this Jan 2, 2022
@algonautshant algonautshant force-pushed the shant/LastPartKeyRound branch from fbe4438 to a4f14ec Compare January 4, 2022 19:00
@algonautshant algonautshant merged commit ea5485d into algorand:feature/dilithium-scheme-integration Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants