-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Falcon key gen time: set LastPartKeyRound 3K #3280
Falcon key gen time: set LastPartKeyRound 3K #3280
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/dilithium-scheme-integration #3280 +/- ##
========================================================================
- Coverage 47.84% 47.82% -0.03%
========================================================================
Files 381 381
Lines 61651 61651
========================================================================
- Hits 29496 29483 -13
- Misses 28734 28741 +7
- Partials 3421 3427 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Is LastPartKeyRound in the template new?
fbe4438
to
a4f14ec
Compare
remove
test
param fromCreateNetworkFromTemplate
Do not override
template.Genesis.LastPartKeyRound
if in test mode or ifALGOTEST
env variable is setupdate test templates to explicitly set the
LastPartKeyRound
to 3k instead of relying on 3M default value.Flag to cap last round of participation key generation, and use the flag for testing.
Enhance notification messages to notify the user the keys are generated.
Reduce LastPartKeyRound for scenarios 1-3.