Use gc to avoid trashing. #3363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/dilithium-scheme-integration #3363 +/- ##
========================================================================
+ Coverage 47.84% 47.86% +0.02%
========================================================================
Files 381 381
Lines 61651 61651
========================================================================
+ Hits 29496 29509 +13
+ Misses 28734 28724 -10
+ Partials 3421 3418 -3
Continue to review full report at Codecov.
|
algonautshant
changed the base branch from
feature/dilithium-scheme-integration
to
master
algonautshant
changed the base branch from
master
to
feature/dilithium-scheme-integration
algorandskiy
approved these changes
Jan 5, 2022
This was referenced Jan 6, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestArchivalFromNonArchival was sporadically failing, particularly on the feature/dilithium-scheme-integration branch.
The most likely reason for the slowdown is narrowed down to system trashing.
This fix seems to fix the issue by invoking GC before the test to have maximum amount of memory available, and after the test to minimize the memory impact on subsequent tests.
This fix is also necessary to confirm the memory hypothesis.
The memory consumption is high because of the existing ledger design, which is skewed in this test by creating a large number of asset creation transactions. This behavior is changing with the upcoming ledger refactoring project.
Resolves #3334