pingpong: improve transaction scheduling #3478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manotoor
reviewed
Mar 22, 2022
brianolson
reviewed
May 25, 2022
shared/pingpong/pingpong.go
Outdated
| } | ||
|
|
||
| *nextSendTime = nextSendTime.Add( | ||
| time.Duration((1.0 / float64(tps)) * float64(time.Second))) |
There was a problem hiding this comment.
Suggested change
| time.Duration((1.0 / float64(tps)) * float64(time.Second))) | |
| time.Duration(float64(time.Second) / float64(tps))) |
There was a problem hiding this comment.
or better yet, at startup, calculate period := Second/tps then later nextSendTime.Add(period)
tolikzinovyev
force-pushed
the
pingpong-sched
branch
from
fb64629 to
7cd4550
Compare
Codecov Report
@@ Coverage Diff @@
## master #3478 +/- ##
==========================================
- Coverage 54.48% 54.46% -0.02%
==========================================
Files 390 390
Lines 48608 48608
==========================================
- Hits 26482 26473 -9
- Misses 19902 19910 +8
- Partials 2224 2225 +1
Continue to review full report at Codecov.
|
tolikzinovyev
added
tech debt
tolikzinovyev
changed the title
brianolson
approved these changes
Jun 1, 2022
algorandskiy
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the transaction scheduling logic in pingpong is lots of complicated sleep calls. Some sleeps were definitely extra and were hurting tps; this PR deprecates them. The whole scheduling logic is replaced with a much simpler one. Let timestamp sequence
{t}_{i >= 0} = {currenttime + 1 / tps * i}. Then transactioniis sent at timet_iwith best effort.In my tests
./pingpong run --tps 115 --rest 0 --refresh 1800 --numaccounts 500produced 440 txns per block. Now./pingpong run --tps 115 --refresh 1800 --numaccounts 500produces 475 txns per block. (--restwas deprecated)Related to https://github.com/algorand/go-algorand-internal/issues/1833.
Test Plan
I ran it.