Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate mss and vc #3512

Merged
merged 5 commits into from
Jan 27, 2022
Merged

Integrate mss and vc #3512

merged 5 commits into from
Jan 27, 2022

Conversation

id-ms
Copy link
Contributor

@id-ms id-ms commented Jan 26, 2022

Summary

Test Plan

@id-ms id-ms linked an issue Jan 26, 2022 that may be closed by this pull request
integrate VC with the merkle signature scheme #3307
Closed
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2022 •
edited
Loading

Codecov Report

Merging #3512 (1b36aa5) into feature/dilithium-scheme-integration (6d44afc) will decrease coverage by 0.01%.
The diff coverage is 57.14%.

Impacted file tree graph

@@                           Coverage Diff                            @@
##           feature/dilithium-scheme-integration    #3512      +/-   ##
========================================================================
- Coverage                                 47.81%   47.80%   -0.02%     
========================================================================
  Files                                       383      383              
  Lines                                     62190    62191       +1     
========================================================================
- Hits                                      29735    29729       -6     
- Misses                                    28999    29003       +4     
- Partials                                   3456     3459       +3
Impacted Files Coverage Δ
crypto/compactcert/verifier.go 65.00% <0.00%> (ø)
ledger/ledgercore/votersForRound.go 0.00% <0.00%> (ø)
crypto/compactcert/builder.go 65.51% <100.00%> (ø)
crypto/merklearray/proof.go 100.00% <100.00%> (ø)
crypto/merklekeystore/keystore.go 63.41% <100.00%> (ø)
crypto/merkletrie/node.go 90.69% <0.00%> (-2.80%) ⬇️
network/wsPeer.go 65.83% <0.00%> (-2.23%) ⬇️
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
network/wsNetwork.go 63.09% <0.00%> (+0.29%) ⬆️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d44afc...1b36aa5. Read the comment docs.

@id-ms id-ms force-pushed the integrate-MSS-and-VC branch from 1b36aa5 to 6d4f50c Compare January 27, 2022 08:14
@id-ms id-ms requested a review from Aharonee January 27, 2022 08:38
Aharonee
Aharonee approved these changes Jan 27, 2022
View reviewed changes
@id-ms id-ms merged commit 3750eb7 into algorand:feature/dilithium-scheme-integration Jan 27, 2022
@egieseke egieseke mentioned this pull request Feb 16, 2022
Closed
PhearZero pushed a commit to PhearNet/crypto that referenced this pull request Jan 17, 2025
@id-ms
Integrate mss and vc (algorand#3512)
2e056dd 
* compact cert use VC

* use vc in MSS

* proof encoding contains leading zeros

* fix some nits

* CR fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aharonee Aharonee Aharonee approved these changes

Assignees
No one assigned
Labels
Team Sphinx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

integrate VC with the merkle signature scheme
3 participants
@id-ms @codecov-commenter @Aharonee