Only allow access to txn effects for previous transactions #3529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonpaulos
reviewed
Jan 28, 2022
data/transactions/logic/eval.go
Outdated
|
|
||
| itxn := &cx.Txn.EvalDelta.InnerTxns[len(cx.Txn.EvalDelta.InnerTxns)-1] | ||
| sv, err := cx.txnFieldToStack(itxn, fs, arrayFieldIdx, 0, true) | ||
| sv, err := cx.opTxnImpl(0, srcGroup, field, ai, true) |
data/transactions/logic/eval.go
Outdated
Comment on lines
2272
to
2274
| const srcGroup txnSource = 0 | ||
| const srcInner txnSource = 1 | ||
| const srcInnerGroup txnSource = 2 |
There was a problem hiding this comment.
Suggested change
| const srcGroup txnSource = 0 | |
| const srcInner txnSource = 1 | |
| const srcInnerGroup txnSource = 2 | |
| const ( | |
| srcGroup txnSource = 0 | |
| srcInner = 1 | |
| srcInnerGroup = 2 | |
| ) |
nit: this would be more recognizable as an enum like this
There was a problem hiding this comment.
I'll even go full on iota on it
data/transactions/logic/eval.go
Outdated
| tx := &group[gi] | ||
|
|
||
| // int(gi) is safe because gi < len(group). Slices in Go cannot exceed `int` | ||
| sv, err = cx.txnFieldToStack(tx, fs, ai, int(gi), src != srcGroup) | ||
| if err != nil { | ||
| cx.err = err |
There was a problem hiding this comment.
nit: there's inconsistent use of cx.err. This check sets it, but all other checks in this function don't
There was a problem hiding this comment.
thanks. oddly enough that ends up having the exact same effect, but was certainly not intended
Next up, eliminate this cx.err assignment thing in all the opcodes.
jasonpaulos
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
txn opcodes should not be able to look at the current or future "effects" fields