-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving windows build to Github Actions #3575
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3575 +/- ##
==========================================
- Coverage 47.58% 47.58% -0.01%
==========================================
Files 370 370
Lines 60118 60118
==========================================
- Hits 28606 28605 -1
- Misses 28198 28199 +1
Partials 3314 3314
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The python version is interesting, but otherwise looks alright to me.
Removed, got it from circleci attempt to implement this, but seems we don't need it. |
Moved it to build-test-windows here on Github.
Artifact gathering and upload are not currently working, since they seem to be cached files and we are not sure how useful those are. But if we can determine what exactly we need and for what purpose, we can add them back in.
Slack notifications for failed nightly builds added using slack webhook to #dev-alerts channel.
Travis integration removed.
Example slack message:
