Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match old BuildEvalDelta behaviour - no delete missing keys #3594

Conversation

jannotti
Copy link
Contributor

@jannotti jannotti commented Feb 8, 2022

Deleting keys that don't exist should not go into EvalDelta

@codecov-commenter
Copy link

Codecov Report

Merging #3594 (867c358) into feature/contract-to-contract (abe3c6a) will increase coverage by 0.00%.
The diff coverage is 53.84%.

Impacted file tree graph

@@                      Coverage Diff                      @@
##           feature/contract-to-contract    #3594   +/-   ##
=============================================================
  Coverage                         47.88%   47.89%           
=============================================================
  Files                               370      370           
  Lines                             60006    60016   +10     
=============================================================
+ Hits                              28736    28742    +6     
  Misses                            27968    27968           
- Partials                           3302     3306    +4     
Impacted Files Coverage Δ
data/transactions/logic/eval.go 85.51% <53.84%> (-0.19%) ⬇️
ledger/blockqueue.go 82.18% <0.00%> (-2.88%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
data/abi/abi_type.go 87.67% <0.00%> (-0.95%) ⬇️
network/wsNetwork.go 62.79% <0.00%> (-0.20%) ⬇️
network/wsPeer.go 68.61% <0.00%> (+0.27%) ⬆️
network/requestTracker.go 71.12% <0.00%> (+0.86%) ⬆️
catchup/service.go 69.62% <0.00%> (+0.98%) ⬆️
cmd/tealdbg/debugger.go 73.86% <0.00%> (+1.00%) ⬆️
util/metrics/counter.go 80.95% <0.00%> (+2.38%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abe3c6a...867c358. Read the comment docs.

@jannotti jannotti merged commit 2c7b906 into algorand:feature/contract-to-contract Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants