C2C merge #3597
Merged
C2C merge #3597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3551) ## Summary Add a warning in case the VotingKeys method surpasses the expected execution time limits. ## Test Plan Tested manually.
## Summary The TestSyncFromClient was randomly failing. This is a real issue in production code, and the fix it pretty trivial. ## Test Plan Use existing tests to verify test.
## Summary * Do not load everything into memory but write directly in into a file This creates extremely high number of reallocation and CPU and RAM wasting. * Add cmd options for downloading only (no loading), and for downloading from a single relay # Perf data: | param | current | new | |-----------|--------|---------| | RAM | 5 GB | 200 MB | | Total time | 823 s | 441 s | Downloading time went down from minutes to tens of seconds.
Our nightly pipeline broke because of centos:8 reaching end of life and deprecating their package repo AppStream. Switching to official new version Centos Stream 8.
## Summary Remove a hardcoded constant in sortition.go which was used as the denominator in determining the selection ratio. This clarifies what the maximum possible output size is of the output VRF based on the SHA algorithm used to generate it. ## Purpose This is simply a code quality change to make it easier to read and understand without any focus on new functionality or performance. It is unlikely that the VRF SHA length used by Algorand will changed, so the generalization to a dynamic length based on the length of the Crypto digest is only for the reader. The use of an `init` function to initialize the `maxFloat` once rather than anytime `sortition` runs is a minor optimization, but likely to be neglibile in the grand scheme of things. ## Test Plan Due to the usage of C src code, a simple `go test -v ./data/committee/sortition/` cannot be executed without the proper configurations. However, circle CI should be able to execute the unit tests automatically and verify the changes. Recommendation: Running the recommended make targets to test the changes did not automatically due to missing dependencies, so potentially a Dockerfile could help resolve this for future contributors.
## Summary Added a new option `--exclude-fields` to `file` subcommand. This simplifies large dumps comparison by excluding all exclude some header fields. Also moved some shared cmd code into a new cmdutil package. ## Test Plan Tested manually
Adds commentary based on context found in #2730.
* adding another field for lsig disassembly * generate oas3 * rename to match other keys * adding trace, just to see * nevermind * fix w/jj comment
## Summary Following up on #3558, this PR update the THANKS.md file. ## Test Plan Not required for this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.