Use context instead of an atomic variable #3599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winder
reviewed
Feb 9, 2022
| @@ -240,7 +241,7 @@ func TestSigning(t *testing.T) { | |||
|
|
|||
| err = signer.GetVerifier().Verify(start+5, hashable, sig) | |||
| a.Error(err) | |||
| a.Contains(err.Error(), ErrSignatureSchemeVerificationFailed) | |||
| a.True(errors.Is(err, ErrSignatureSchemeVerificationFailed)) | |||
There was a problem hiding this comment.
nit: newer versions of testify have ErrorIs https://pkg.go.dev/github.com/stretchr/testify/require?utm_source=godoc#ErrorIs
Codecov Report
@@ Coverage Diff @@
## feature/dilithium-scheme-integration #3599 +/- ##
=========================================================================
+ Coverage 29.04% 47.90% +18.85%
=========================================================================
Files 381 381
Lines 61878 61879 +1
=========================================================================
+ Hits 17975 29643 +11668
+ Misses 41451 28807 -12644
- Partials 2452 3429 +977
Continue to review full report at Codecov.
|
cce
approved these changes
Feb 9, 2022
PhearZero
pushed a commit
to PhearNet/crypto
that referenced
this pull request
Jan 17, 2025
Use context instead of an atomic variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Switch the usage of a atomic variable with a context.
Test Plan
The updated tests seems to be failing due to unrelated issues, and these are fixed now.