Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-algorand 3.5.0-beta #3719

Merged
merged 17 commits into from
Mar 7, 2022
Merged

Conversation

Algo-devops-service
Copy link
Contributor

@Algo-devops-service Algo-devops-service commented Mar 4, 2022

GitHub Logo

What's New

  • Accounts can now create and opt in to an unlimited number of assets and applications

Protocol Upgrade

This release contains a protocol upgrade.

Changelog

Enhancement

Additional Resources

algojohnlee and others added 17 commits March 1, 2022 11:06
)

## Summary

Provides a pointer to instructions added in algorand/indexer#906 for updating Indexer E2E test input.

## Test Plan

N/A - Changes docs.  Though I expect to trial the instructions as discussed in algorand/indexer#906.
…4.2-remerge

go-algorand relstable3.4.2-remerge
## Summary

This PR adds support of for unlimited assets.

Done:
- [x] Update this title
- [x] Complete & Merge the implementation of the accounts prefetched during the validation (algorand#3666)
- [x] Create & Merge a spec update ( algorandfoundation/specs#62 (comment) )
- [x] Create & Merge a consensus upgrade (algorand#3674)

## Test Plan

Extend, update and add new unit tests.
## Summary
Refactored WriteThread such that it'll be easier to add new operations. 
Didn't delete the DBs`inner` functions, instead moved them to be handled by a struct that implements `dbOp` interface
…tion (algorand#3707)

## Summary

Follow-on to algorand#3702, the copy-pasted code in AccountApplicationInformation was checking the wrong value before returning AppParams.
## Summary

This adds configuration options to adjust the sizes of buffered channels used by the agreement system for incoming messages. 

## Test Plan

Existing tests should pass.
…ails message (algorand#3703)

## Summary

This pulls a bit of code from the the [pipelining branch](https://github.com/algorand/go-algorand/tree/feature/pipeline) to add a "validatedAt" duration field to the agreement.proposal type. This is used to provide an extra field in the BlockAcceptedEventDetails message describing how soon into the round each block was validated.

## Test Plan

Existing tests should pass, and a new test might be helpful to show that the value is getting filled in correctly.
Summary

The existing code was failing the fast catchup on node startup if the peers could not be retrieved from the network package.
Unfortunately, this is almost always the case. This change allow the node to retry fetching the peers list from the network package multiple times, while having a short delay between the iterations.

This issue was reported by a Algorand Forum member.

Test Plan

Test the change manually.
…nd#3710)

## Summary

The TestAssetConfig was not updated correctly to support unlimited assets.
This PR brings it up to date, as well as improve the runtime of the test.

## Test Plan

Use Circle-CI.
## Summary

Similar to algorand#1938 this adds the TagCounter to report message counters by type. It also removes labels from the existing Counters, which should improve their performance.

## Test Plan

Existing tests should pass.
…lgorand#3708)

## Summary

This replaces the various Ledger interfaces' `LookupResource` method with two more specific `LookupApplication` and `LookupAsset` methods. Following up on code review feedback from algorand#3652.

## Test Plan

Existing tests should pass, including the ones that implement their own mock ledger.
## Summary

There was one Clock implementation not updated in algorand#3703 in the agreement fuzzer testing package's NetworkFacade type. This updates it to fully implement the Clock interface.
## Summary

The `satori/go.uuid` dependency was reported to contain a vulnerability ( https://nvd.nist.gov/vuln/detail/CVE-2021-3538#VulnChangeHistorySection ).

While this vulnerability would have no negative impact on the Algorand blockchain, it does mislead automated vulnerability detectors and points the Algorand codebase to be considered insecure.

Given that this package was used in so few locations, and in such a small scope, I have removed the usage of it completely. Instead, I have implemented a random UUID which would work correctly for our needs.

## Test Plan

Unit tests added.
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2022

Codecov Report

Merging #3719 (f33f2bd) into rel/beta (6b7dfb6) will decrease coverage by 0.34%.
The diff coverage is 45.55%.

Impacted file tree graph

@@             Coverage Diff              @@
##           rel/beta    #3719      +/-   ##
============================================
- Coverage     49.92%   49.57%   -0.35%     
============================================
  Files           382      392      +10     
  Lines         64411    68588    +4177     
============================================
+ Hits          32158    34004    +1846     
- Misses        28817    30845    +2028     
- Partials       3436     3739     +303     
Impacted Files Coverage Δ
agreement/proposal.go 71.96% <ø> (ø)
catchup/catchpointService.go 0.00% <0.00%> (ø)
catchup/ledgerFetcher.go 37.63% <0.00%> (-7.24%) ⬇️
cmd/goal/application.go 11.16% <0.00%> (-0.02%) ⬇️
cmd/goal/interact.go 3.35% <0.00%> (-0.01%) ⬇️
config/localTemplate.go 42.85% <ø> (ø)
config/version.go 9.09% <ø> (ø)
daemon/algod/api/server/router.go 14.70% <0.00%> (-0.45%) ⬇️
daemon/algod/api/server/v1/handlers/handlers.go 0.63% <0.00%> (+<0.01%) ⬆️
daemon/algod/api/server/v2/handlers.go 0.00% <0.00%> (ø)
... and 105 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b7dfb6...f33f2bd. Read the comment docs.

@egieseke egieseke marked this pull request as ready for review March 6, 2022 03:31
@egieseke egieseke self-assigned this Mar 6, 2022
@algobarb algobarb requested a review from onetechnical March 7, 2022 14:02
Copy link
Contributor

@algobarb algobarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@algojohnlee algojohnlee merged commit 13d95bf into algorand:rel/beta Mar 7, 2022
@onetechnical onetechnical deleted the relbeta3.5.0 branch March 7, 2022 14:25
PhearZero pushed a commit to PhearNet/crypto that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants