Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST client: always set Exclude value in accountInformationParams #3728

Merged
merged 2 commits into from
Mar 25, 2022
Merged

REST client: always set Exclude value in accountInformationParams #3728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16e63d3
nit: always set Exclude value in accountInformationParams
cce Mar 7, 2022
2b7d31d
fix comments from CR
cce Mar 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion daemon/algod/api/client/restClient.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ func (client RestClient) AccountInformation(address string) (response v1.Account
func (client RestClient) AccountInformationV2(address string, includeCreatables bool) (response generatedV2.Account, err error) {
var infoParams accountInformationParams
if includeCreatables {
infoParams = accountInformationParams{Exclude: "", Format: "json"}
infoParams = accountInformationParams{Exclude: "none", Format: "json"}
} else {
infoParams = accountInformationParams{Exclude: "all", Format: "json"}
}
Expand Down
4 changes: 2 additions & 2 deletions libgoal/libgoal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,7 +687,7 @@ func (c *Client) RawAccountApplicationInformation(accountAddress string, applica
return
}

// AccountAssetInformation gets account information about a given app.
// AccountAssetInformation gets account information about a given asset.
func (c *Client) AccountAssetInformation(accountAddress string, assetID uint64) (resp generatedV2.AccountAssetResponse, err error) {
algod, err := c.ensureAlgodClient()
if err == nil {
Expand All @@ -696,7 +696,7 @@ func (c *Client) AccountAssetInformation(accountAddress string, assetID uint64)
return
}

// RawAccountAssetInformation gets account information about a given app.
// RawAccountAssetInformation gets account information about a given asset.
func (c *Client) RawAccountAssetInformation(accountAddress string, assetID uint64) (accountResource modelV2.AccountAssetModel, err error) {
algod, err := c.ensureAlgodClient()
if err == nil {
Expand Down