Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: update Test5MAssetsScenario e2e test #3750

Merged
merged 3 commits into from
Mar 11, 2022

Conversation

tsachiherman
Copy link
Contributor

Summary

This PR improves the test in the following ways:

  1. The checkPoint method is no longer timer-based; instead, it's using the WaitForBlock which moves the blocking operation to the node.
  2. The generated accounts secret keys are now deterministic. This would allows repeated runs to have the same set of keys.
  3. More testing was added for return variables across the test.

Test Plan

This is a test.

Copy link
Contributor

@algonautshant algonautshant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.
But I am concerned that if and when the test stalls (i.e. the node) it will be difficult to identify it.

@tsachiherman tsachiherman merged commit a974e34 into algorand:master Mar 11, 2022
@tsachiherman tsachiherman deleted the tsachi/accountstesting2 branch March 11, 2022 16:53
jannotti pushed a commit to jannotti/go-algorand that referenced this pull request Mar 13, 2022
## Summary

This PR improves the test in the following ways:
1. The checkPoint method is no longer timer-based; instead, it's using the WaitForBlock which moves the blocking operation to the node.
2. The generated accounts secret keys are now deterministic. This would allows repeated runs to have the same set of keys.
3. More testing was added for return variables across the test.

## Test Plan

This is a test.
@algojack algojack mentioned this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants