-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goal: Add check for signer passed in the case of logic sig rekeyed account #3773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For me, this PR was abit confusing since it was completely omitting the fact that we're taking about a logicsig account that was rekeyed. |
Could you please take a look on the test failures ?
|
tsachiherman
approved these changes
Mar 17, 2022
tsachiherman
approved these changes
Mar 18, 2022
This was referenced Apr 27, 2022
This was referenced May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When trying to sign a transaction file with goal, if the sender is a normal address but the signer is a logic program, the call fails with an error message like:
send.txn: txn[0] error LogicNot signed and not a Logic-only account
The error message comes from
go-algorand/data/transactions/verify/txn.go
Line 314 in 33b87c4
It notes that a valid case is when Auth is set to the hash of the program but we aren't setting the auth on the transaction even if the -S flag is passed
Test Plan
Made a txn where sender is a regular account and signed it with
I borked the git history on the last one #3459 so just nuked it and starting over here.
Left it at @tsachiherman wanting better tests for this #3459 (comment)