Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add build essentials to dependency list #3782

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

winder
Copy link
Contributor

@winder winder commented Mar 16, 2022

Summary

On Ubuntu 21.10 g++ was required and missing after running configure_dev.sh

Here is the error:

go build github.com/algorand/go-algorand/data/committee/sortition: g++: exec: "g++": executable file not found in $PATH

Test Plan

The build now completes.

@winder winder requested a review from tsachiherman March 16, 2022 17:19
@winder winder self-assigned this Mar 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2022

Codecov Report

Merging #3782 (d8a0e69) into master (d3dc437) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3782      +/-   ##
==========================================
- Coverage   49.68%   49.65%   -0.03%     
==========================================
  Files         392      392              
  Lines       68588    68588              
==========================================
- Hits        34076    34060      -16     
- Misses      30766    30785      +19     
+ Partials     3746     3743       -3     
Impacted Files Coverage Δ
ledger/blockqueue.go 82.18% <0.00%> (-2.88%) ⬇️
util/metrics/gauge.go 68.00% <0.00%> (-2.67%) ⬇️
util/metrics/counter.go 78.57% <0.00%> (-2.39%) ⬇️
node/node.go 23.33% <0.00%> (-1.86%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
data/abi/abi_type.go 87.67% <0.00%> (-0.95%) ⬇️
network/requestTracker.go 70.25% <0.00%> (-0.87%) ⬇️
ledger/acctupdates.go 69.08% <0.00%> (ø)
cmd/algoh/blockWatcher.go 77.77% <0.00%> (ø)
network/wsNetwork.go 62.99% <0.00%> (+0.19%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3dc437...d8a0e69. Read the comment docs.

tsachiherman
tsachiherman previously approved these changes Mar 16, 2022
@tsachiherman tsachiherman changed the title Add build essentials to dependency list. build: add build essentials to dependency list Mar 16, 2022
@winder winder added the bug Something isn't working label Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Enhancement Team Lamprey
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants