Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add some warning comments about changing RewardUnit value #3846

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

algorandskiy
Copy link
Contributor

No description provided.

@algorandskiy algorandskiy requested a review from cce March 29, 2022 23:38
@algorandskiy algorandskiy self-assigned this Mar 29, 2022
@algorandskiy algorandskiy force-pushed the pavel/consensus-comments branch from b507769 to 7dfca75 Compare March 29, 2022 23:41
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2022

Codecov Report

Merging #3846 (7dfca75) into master (d8ea805) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3846      +/-   ##
==========================================
- Coverage   49.99%   49.98%   -0.01%     
==========================================
  Files         393      393              
  Lines       68390    68390              
==========================================
- Hits        34190    34185       -5     
- Misses      30463    30470       +7     
+ Partials     3737     3735       -2     
Impacted Files Coverage Δ
config/consensus.go 85.53% <ø> (ø)
data/bookkeeping/block.go 55.23% <ø> (ø)
ledger/blockqueue.go 82.18% <0.00%> (-2.88%) ⬇️
network/wsPeer.go 65.83% <0.00%> (-2.23%) ⬇️
agreement/cryptoVerifier.go 68.08% <0.00%> (-2.13%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
cmd/tealdbg/debugger.go 71.42% <0.00%> (-0.99%) ⬇️
network/wsNetwork.go 62.99% <0.00%> (+0.19%) ⬆️
catchup/service.go 69.62% <0.00%> (+0.24%) ⬆️
data/transactions/verify/txn.go 45.02% <0.00%> (+0.86%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8ea805...7dfca75. Read the comment docs.

@algorandskiy algorandskiy changed the title Add some warning comments about changing RewardUnit value config: add some warning comments about changing RewardUnit value Mar 30, 2022
@algorandskiy algorandskiy merged commit 9d9d759 into algorand:master Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants