Enhancement: Re-enable fillBytes method in ABI and eval.go implementation
#3856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3856 +/- ##
==========================================
- Coverage 49.97% 49.97% -0.01%
==========================================
Files 393 393
Lines 68390 68353 -37
==========================================
- Hits 34181 34160 -21
+ Misses 30473 30464 -9
+ Partials 3736 3729 -7
Continue to review full report at Codecov.
|
ahangsu
changed the title
fillBytes method in ABI implementationfillBytes method in ABI and eval.go implementation
jannotti
reviewed
Apr 2, 2022
| @@ -3070,7 +3014,7 @@ func opEcdsaPkDecompress(cx *EvalContext) error { | |||
| return fmt.Errorf("invalid pubkey") | |||
| } | |||
| } else if fs.field == Secp256r1 { | |||
| x, y = unmarshalCompressed(elliptic.P256(), pubkey) | |||
| x, y = elliptic.UnmarshalCompressed(elliptic.P256(), pubkey) | |||
There was a problem hiding this comment.
Should we retest the speed of decompress to reconsider opcode cost? Or was our implementation the same as this library function?
There was a problem hiding this comment.
The previous (un)marshalCompressed was copying the library implementation, so I felt like this should not change the speed.
This was referenced Apr 27, 2022
This was referenced May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current go-algorand build is over golang 1.16, which means we can revert #3498.
#3498 is introduced for the sake of downgrading golang for perf issues, now we should lift back to earlier implementation.
We also re-enable
FillBytesinleadingZeroimplementation, and updateelliptic.(un)marshalCompressedfor #2852 .