-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVM: Assembly simplification & flexible costs #3857
Conversation
f02b8a8
to
2707590
Compare
Codecov Report
@@ Coverage Diff @@
## master #3857 +/- ##
==========================================
- Coverage 50.00% 49.98% -0.02%
==========================================
Files 393 393
Lines 68353 68200 -153
==========================================
- Hits 34178 34090 -88
+ Misses 30450 30404 -46
+ Partials 3725 3706 -19
Continue to review full report at Codecov.
|
9460fb3
to
74aba7a
Compare
Unify most assembly routines to minimize difference and ease doc gen Flexible opcode costs and fewer assembly routines
74aba7a
to
6c167eb
Compare
…anges Remove unused function: typeEnumTableMarkdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through everything (thanks JJ for answering questions live) - leaving final approval to folks closer to the AVM. Highly supportive of the consolidation around how costs are handled; it is much easier to follow having them calculated/displayed off of a common type with the inputs gathered together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jannotti Thanks for the effort here to enrich the cost model while also simplifying assembly. ☕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
acct_params_get
is missing fields and types in langspec.json file
#3862 adds them |
Removes the need for writing many assembly routines, and adds flexibility to opcode cost model.