AVM: inner appls can call v4 #3896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3896 +/- ##
==========================================
+ Coverage 50.01% 50.05% +0.04%
==========================================
Files 393 393
Lines 68295 68316 +21
==========================================
+ Hits 34156 34196 +40
+ Misses 30433 30415 -18
+ Partials 3706 3705 -1
Continue to review full report at Codecov.
|
AllowV4InnerAppls also means that apps can not perform an inner opt-in to apps with <v4 CSP (since they might then be locked in). And no app can downgrade, as that is a straightforward rule to prevent an app from lowering its CSP and locking other apps into it.
The DoubleLedger does a lot of double checking on ledgers produced by rerunning transactions after creating blocks, deserializing the txns from the block and validating the results. testConsensusRange makes it easy for ledger tests to test behavior in many protocol levels. A particular problem it handles is that test can be written to run from some consensus version and in every subsequent version. So if we change behavior in a new version, we'll find out.
Co-authored-by: algochoi <[email protected]>
Co-authored-by: algochoi <[email protected]>
Co-authored-by: algochoi <[email protected]>
also converted more tests to testConsensusRange, and t.Parallel()
Review dog found an unused variable, which was a bug. Added tests to check for the bug that would have existed.
michaeldiamant
approved these changes
Apr 27, 2022
There was a problem hiding this comment.
@jannotti Thanks for working through a few rounds of feedback from my side. ☕
This was referenced May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows inner app calls to v4 and v5 teal versions. The following prohibitions were added to make this safe.
Rule 1 ensures that an app can call the clearstate program as an inner. Rule 2 prevents an end-run around rule #1, by preventing an app with v5 CSP from downgrading to v3 at a later time.
The PR also introduces a DoubleLedger and testConsensusRange to make it easier to write ledger tests that need to operate over different consensus versions. It also makes it easy to write the tests in such a way that they continue to test the functionality they care about as we change the consensus version, but also continue to test the behavior on old version, to prevent regressions.