diagcfg: Allow diagcfg to create logging.config in data directory. #3912
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When running diagcfg as a user without a home directory, the missing global default directory prevents diagcfg from writing
logging.config
. With this change, the error is cleared out so that the file can be created as usual.The only risk is if the global logging file was being used, and is for some reason temporarily inaccessible, those defaults would not be copied into the new file.
Test Plan
Manual testing.
Run diagcfg with ALGORAND_DATA and -d, the file is created in the data directory.
Run diagcfg without ALGORAND_DATA or -d, the file is created in the default global directory.
Also tested on a docker environment where the user did not have a home directory (or default global directory), the logging file is created in the data directory.