-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DevOps: Define recipe for FastNet. #4066
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some notes...probably need to sync with Chris to ensure the genesis has the changes he needs. It may also take a long time if we need to extend the partkey validity time.
test/testdata/deployednettemplates/recipes/fastnet/genesis.json
Outdated
Show resolved
Hide resolved
test/testdata/deployednettemplates/recipes/fastnet/genesis.json
Outdated
Show resolved
Hide resolved
"VersionModifier": "", | ||
"ConsensusProtocol": "future", | ||
"FirstPartKeyRound": 0, | ||
"LastPartKeyRound": 30000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this too short? This would have been about 36 hours for a perf network, but for a long-lived network we want this to be much, much longer unless we're going to go through and renew partkeys ourselves. At 3m rounds it's only about 87 days if our rounds are 2.5s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, we should choose a bigger value for this longer-running network. It will take several hours to make all the keys though (depending on how many cores you have when running netgoal)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted back to 3 million rounds.
@@ -0,0 +1,32 @@ | |||
node_types = {"R":6, "N":12, "NPN":6} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this round I'm kind of okay with mimicking betanet in terms of composition and distribution. Is this 24 non-co-located nodes? This seems like a lot until we can iron out some details.
@cce Any thoughts on this? I'm kind of okay with the 5 instance (1 relay + 4 partnode) setup to launch at this round while we evaluate our changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, however you think is best to roll it out, I assume it is relatively easy to update and grow the network as needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, reduced to 1 relay, 4 nodes, and 2 NPNs.
@@ -0,0 +1,104 @@ | |||
{ | |||
"NetworkName": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might as well name this alphanet right from the start!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed to alphanet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed with @onetechnical on his points and would like to see EnableRuntimeMetrics added to config
@@ -0,0 +1,32 @@ | |||
node_types = {"R":6, "N":12, "NPN":6} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, however you think is best to roll it out, I assume it is relatively easy to update and grow the network as needed
test/testdata/deployednettemplates/recipes/fastnet/gen_topology.py
Outdated
Show resolved
Hide resolved
made suggested changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have 2, 4, and even 8 character spacing/tabs in these files, should we maybe have a standard? or at least stick with 2 and 4 (not 8?)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the update to the gen_topology.py
, approving that that change, but should probably wait until @onetechnical and/or @cce take a look again.
… create-fastnet-recipe
Used this recipe to start alphanet network: alphanet.algodev.network |
Codecov Report
@@ Coverage Diff @@
## master #4066 +/- ##
==========================================
- Coverage 54.55% 54.47% -0.08%
==========================================
Files 391 391
Lines 48662 48662
==========================================
- Hits 26546 26511 -35
- Misses 19890 19926 +36
+ Partials 2226 2225 -1
Continue to review full report at Codecov.
|
Summary
Define the Algonet recipe to support Alphanet testing.
Test Plan
Deploy and test the network.