Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevOps: Define recipe for FastNet. #4066

Merged
merged 4 commits into from
Jun 8, 2022

Conversation

egieseke
Copy link
Contributor

@egieseke egieseke commented Jun 2, 2022

Summary

Define the Algonet recipe to support Alphanet testing.

Test Plan

Deploy and test the network.

Copy link
Contributor

@onetechnical onetechnical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some notes...probably need to sync with Chris to ensure the genesis has the changes he needs. It may also take a long time if we need to extend the partkey validity time.

"VersionModifier": "",
"ConsensusProtocol": "future",
"FirstPartKeyRound": 0,
"LastPartKeyRound": 30000,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this too short? This would have been about 36 hours for a perf network, but for a long-lived network we want this to be much, much longer unless we're going to go through and renew partkeys ourselves. At 3m rounds it's only about 87 days if our rounds are 2.5s

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, we should choose a bigger value for this longer-running network. It will take several hours to make all the keys though (depending on how many cores you have when running netgoal)

Copy link
Contributor Author

@egieseke egieseke Jun 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted back to 3 million rounds.

@@ -0,0 +1,32 @@
node_types = {"R":6, "N":12, "NPN":6}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this round I'm kind of okay with mimicking betanet in terms of composition and distribution. Is this 24 non-co-located nodes? This seems like a lot until we can iron out some details.

@cce Any thoughts on this? I'm kind of okay with the 5 instance (1 relay + 4 partnode) setup to launch at this round while we evaluate our changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, however you think is best to roll it out, I assume it is relatively easy to update and grow the network as needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, reduced to 1 relay, 4 nodes, and 2 NPNs.

@@ -0,0 +1,104 @@
{
"NetworkName": "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well name this alphanet right from the start!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to alphanet.

cce
cce previously requested changes Jun 2, 2022
Copy link
Contributor

@cce cce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with @onetechnical on his points and would like to see EnableRuntimeMetrics added to config

@@ -0,0 +1,32 @@
node_types = {"R":6, "N":12, "NPN":6}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, however you think is best to roll it out, I assume it is relatively easy to update and grow the network as needed

@egieseke egieseke dismissed stale reviews from cce and onetechnical June 6, 2022 17:31

made suggested changes

Copy link
Contributor

@algojack algojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have 2, 4, and even 8 character spacing/tabs in these files, should we maybe have a standard? or at least stick with 2 and 4 (not 8?)?

Copy link
Contributor

@algolucky algolucky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update to the gen_topology.py, approving that that change, but should probably wait until @onetechnical and/or @cce take a look again.

@egieseke
Copy link
Contributor Author

egieseke commented Jun 7, 2022

Used this recipe to start alphanet network: alphanet.algodev.network

@egieseke egieseke closed this Jun 7, 2022
@egieseke egieseke reopened this Jun 7, 2022
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #4066 (a196818) into master (febeb1e) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4066      +/-   ##
==========================================
- Coverage   54.55%   54.47%   -0.08%     
==========================================
  Files         391      391              
  Lines       48662    48662              
==========================================
- Hits        26546    26511      -35     
- Misses      19890    19926      +36     
+ Partials     2226     2225       -1     
Impacted Files Coverage Δ
ledger/blockqueue.go 82.18% <0.00%> (-2.88%) ⬇️
agreement/cryptoVerifier.go 67.60% <0.00%> (-2.12%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
node/node.go 22.42% <0.00%> (-1.87%) ⬇️
ledger/tracker.go 73.16% <0.00%> (-1.30%) ⬇️
catchup/service.go 68.88% <0.00%> (-1.24%) ⬇️
data/transactions/verify/txn.go 44.15% <0.00%> (-0.87%) ⬇️
network/wsPeer.go 67.67% <0.00%> (-0.83%) ⬇️
cmd/tealdbg/debugger.go 72.69% <0.00%> (-0.81%) ⬇️
network/wsNetwork.go 65.27% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update febeb1e...a196818. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants