Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Fixing calls to pingpong with deprecated flag --rest #4070

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

algojack
Copy link
Contributor

@algojack algojack commented Jun 3, 2022

rest flag was deprecated in the following link, removing it from the rest of go-algorand repo
4e968a2

@algojack algojack requested review from cce, tolikzinovyev, algorandskiy and a team June 3, 2022 15:14
@algojack algojack self-assigned this Jun 3, 2022
@algojack algojack changed the title removing-pingpong-deprecated-flag-rest removing pingpong deprecated flag --rest Jun 3, 2022
@algojack algojack changed the title removing pingpong deprecated flag --rest removing calls to pingpong deprecated flag --rest Jun 3, 2022
@algojack algojack changed the title removing calls to pingpong deprecated flag --rest fixing calls to pingpong with deprecated flag --rest Jun 3, 2022
@onetechnical onetechnical changed the title fixing calls to pingpong with deprecated flag --rest Tools: Fixing calls to pingpong with deprecated flag --rest Jun 3, 2022
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #4070 (46a245c) into master (4e968a2) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4070      +/-   ##
==========================================
- Coverage   54.55%   54.47%   -0.08%     
==========================================
  Files         391      391              
  Lines       48665    48665              
==========================================
- Hits        26549    26512      -37     
- Misses      19890    19926      +36     
- Partials     2226     2227       +1     
Impacted Files Coverage Δ
cmd/algoh/blockWatcher.go 77.77% <0.00%> (-3.18%) ⬇️
ledger/blockqueue.go 82.18% <0.00%> (-2.88%) ⬇️
node/node.go 23.12% <0.00%> (-1.84%) ⬇️
catchup/service.go 68.64% <0.00%> (-1.49%) ⬇️
ledger/tracker.go 75.32% <0.00%> (-1.30%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
ledger/acctupdates.go 68.77% <0.00%> (-0.66%) ⬇️
network/wsPeer.go 67.67% <0.00%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e968a2...46a245c. Read the comment docs.

@algorandskiy algorandskiy merged commit 9adda1d into master Jun 3, 2022
@cce cce deleted the removing-pingpong-deprecated-flag-rest branch June 15, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants