Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger: fix flakiness in TestReproducibleCatchpointLabels #4074

Merged

Conversation

tolikzinovyev
Copy link
Contributor

Summary

Similar to #4068.

Test Plan

Ran TestReproducibleCatchpointLabels.

@codecov
Copy link

codecov bot commented Jun 4, 2022

Codecov Report

Merging #4074 (39d6f2d) into master (9adda1d) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4074      +/-   ##
==========================================
+ Coverage   54.44%   54.51%   +0.07%     
==========================================
  Files         391      391              
  Lines       48665    48665              
==========================================
+ Hits        26494    26532      +38     
+ Misses      19943    19913      -30     
+ Partials     2228     2220       -8     
Impacted Files Coverage Δ
catchup/service.go 68.14% <0.00%> (-0.75%) ⬇️
network/wsNetwork.go 64.98% <0.00%> (+0.19%) ⬆️
ledger/acctupdates.go 69.43% <0.00%> (+0.65%) ⬆️
cmd/tealdbg/debugger.go 73.49% <0.00%> (+0.80%) ⬆️
network/wsPeer.go 70.41% <0.00%> (+4.93%) ⬆️
ledger/tracker.go 76.62% <0.00%> (+6.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9adda1d...39d6f2d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants